After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790385 - meson: Don't require gobject-introspection
meson: Don't require gobject-introspection
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-11-15 16:04 UTC by Jeremy Bicha
Modified: 2017-12-17 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: Don't require gobject-introspection (977 bytes, patch)
2017-11-15 16:04 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-11-15 16:04:17 UTC 
This dependency check doesn't look like it's actually needed or used.
Comment 1 Jeremy Bicha 2017-11-15 16:04:20 UTC 
Created attachment 363705 [details] [review]
meson: Don't require gobject-introspection
Comment 2 Sam Thursfield 2017-12-16 14:38:23 UTC 
Review of attachment 363705 [details] [review]:

We do need gobject-introspection to produce our bindings, however the Meson gnome.generate_gir() function will also look for the dependency: https://github.com/mesonbuild/meson/blob/master/mesonbuild/modules/gnome.py#L401

So it's fine to merge this.
Comment 3 Sam Thursfield 2017-12-16 14:44:12 UTC 
 I accidentally merged to tracker.git as well as tracker-miners.git, but we do still need the dependency in tracker.git as we have to manually merge the C and Vala .gir information for libtracker-sparql.
Comment 4 Carlos Garnacho 2017-12-17 11:27:58 UTC 
And it's been properly reverted, makes sense. Closing as fixed.