After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790316 - renderer/native: Also wrap flip closures for EGLStreams
renderer/native: Also wrap flip closures for EGLStreams
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-11-14 08:12 UTC by Jonas Ådahl
Modified: 2018-06-07 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
renderer/native: Also wrap flip closures for EGLStreams (5.98 KB, patch)
2017-11-14 08:12 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2017-11-14 08:12:14 UTC 
The multi-GPU feature introduction broke EGLstream support. See attached patch for fix.
Comment 1 Jonas Ådahl 2017-11-14 08:12:22 UTC 
Created attachment 363559 [details] [review]
renderer/native: Also wrap flip closures for EGLStreams

When using the EGLStream backend, the MetaRendererNative passed a
GClosure to KMS when using EGLStreams, but KMS flip callback event
handler in meta-gpu-kms.c expected a closure wrapped in a closure
container, meaning it'd instead crash when using EGLStreams. Make the
flip handler get what it expects also when using EGLStreams by wrapping
the flip closure in the container before handing it over to EGL.
Comment 2 Miguel A. Vico Moya 2017-11-28 01:05:09 UTC 
Review of attachment 363559 [details] [review]:

Looks good to me.
Comment 3 Jonas Ådahl 2018-06-07 20:16:26 UTC 
Attachment 363559 [details] pushed as 8ee14a7 - renderer/native: Also wrap flip closures for EGLStreams