After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790112 - decklink: Ignore some driver-set timecode flags
decklink: Ignore some driver-set timecode flags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-09 09:47 UTC by Vivia Nikolaidou
Modified: 2018-01-27 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
decklink: Ignore some driver-set timecode flags (1.68 KB, patch)
2017-11-09 09:47 UTC, Vivia Nikolaidou
committed Details | Review
decklink: remove unused variable (1.54 KB, patch)
2017-11-09 10:16 UTC, Víctor Manuel Jáquez Leal
rejected Details | Review

Description Vivia Nikolaidou 2017-11-09 09:47:13 UTC
See commit message
Comment 1 Vivia Nikolaidou 2017-11-09 09:47:17 UTC
Created attachment 363283 [details] [review]
decklink: Ignore some driver-set timecode flags

The "fields" flag is ignored because currently GStreamer doesn't support
having only top or only bottom fields inside a frame. The "drop frame"
flag is ignored because some occurrences have been spotted where it
wasn't set while it should have been. In practice, when we have 29.97 or
59.94 FPS, it's always drop-frame.
Comment 2 Víctor Manuel Jáquez Leal 2017-11-09 10:16:29 UTC
Created attachment 363284 [details] [review]
decklink: remove unused variable

Since commit 5ab660c4 the variable bflags is not used anymore, gettint
a compiler (clang) error:

error: variable ‘bflags’ set but not used [-Werror=unused-but-set-variable]

This patch removes the variable bflags and its assignation.
Comment 3 Sebastian Dröge (slomo) 2017-11-09 10:52:33 UTC
Comment on attachment 363284 [details] [review]
decklink: remove unused variable

A patch for that was merged already a couple of minutes ago, but thanks :)
Comment 4 Tim-Philipp Müller 2018-01-27 11:04:18 UTC
This was pushed some time ago:

commit 5ab660c4e25d2389a26e06c7f325f7a6cbb7fa67
Author: Vivia Nikolaidou <vivia@ahiru.eu>
Date:   Thu Nov 9 11:44:17 2017 +0200

    decklink: Ignore some driver-set timecode flags
    
    The "fields" flag is ignored because currently GStreamer doesn't support
    having only top or only bottom fields inside a frame. The "drop frame"
    flag is ignored because some occurrences have been spotted where it
    wasn't set while it should have been. In practice, when we have 29.97 or
    59.94 FPS, it's always drop-frame.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790112