GNOME Bugzilla – Bug 790112
decklink: Ignore some driver-set timecode flags
Last modified: 2018-01-27 11:04:33 UTC
See commit message
Created attachment 363283 [details] [review] decklink: Ignore some driver-set timecode flags The "fields" flag is ignored because currently GStreamer doesn't support having only top or only bottom fields inside a frame. The "drop frame" flag is ignored because some occurrences have been spotted where it wasn't set while it should have been. In practice, when we have 29.97 or 59.94 FPS, it's always drop-frame.
Created attachment 363284 [details] [review] decklink: remove unused variable Since commit 5ab660c4 the variable bflags is not used anymore, gettint a compiler (clang) error: error: variable ‘bflags’ set but not used [-Werror=unused-but-set-variable] This patch removes the variable bflags and its assignation.
Comment on attachment 363284 [details] [review] decklink: remove unused variable A patch for that was merged already a couple of minutes ago, but thanks :)
This was pushed some time ago: commit 5ab660c4e25d2389a26e06c7f325f7a6cbb7fa67 Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Thu Nov 9 11:44:17 2017 +0200 decklink: Ignore some driver-set timecode flags The "fields" flag is ignored because currently GStreamer doesn't support having only top or only bottom fields inside a frame. The "drop frame" flag is ignored because some occurrences have been spotted where it wasn't set while it should have been. In practice, when we have 29.97 or 59.94 FPS, it's always drop-frame. https://bugzilla.gnome.org/show_bug.cgi?id=790112