Created attachment 363228 [details] [review]
icons: ship app icon

- to move to the great new Flatpak future, Apps should rely on shiping
  their own app icons, their identity. For more context, see

  https://wiki.gnome.org/action/edit/Design/Whiteboards/CoreAppPresentation

i

Does it make sense to make a Flatpak for gnome-control-center?

Review of attachment 363228 [details] [review]:

the commit message's link to this bugzilla starts with ihttps

we also need to change the Icon line in shell/gnome-control-center.desktop.in.in

if you don't want to include the 22x22 file as pointed below I can amend this locally and push, otherwise feel free to push after addressing these issues

::: data/icons/Makefile.am
@@ +7,3 @@
+public_icons = \
+	hicolor_apps_16x16_gnome-control-center.png \
+	hicolor_apps_22x22_gnome-control-center.png \

the patch doesn't include this file for the 22x22 size, if that's intended this needs to go, otherwise can you include that file?

Created attachment 364177 [details] [review]
icons: ship app icon

- to move to the great new Flatpak future, Apps should rely on shiping
  their own app icons, their identity. For more context, see

  https://wiki.gnome.org/action/edit/Design/Whiteboards/CoreAppPresentation

Review of attachment 364177 [details] [review]:

looks fine, thanks

::: shell/cc-window.c
@@ +44,3 @@
 #define MOUSE_BACK_BUTTON 8
 
+#define DEFAULT_WINDOW_ICON_NAME "gnome-control-center"

good catch

Attachment 364177 [details] pushed as 5d32d85 - icons: ship app icon