After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789878 - rtpg722pay: Add encoding-params to the src caps template
rtpg722pay: Add encoding-params to the src caps template
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-03 18:31 UTC by Youness Alaoui
Modified: 2017-11-04 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpg722pay: Add encoding-params to the src caps template (1.38 KB, patch)
2017-11-03 18:31 UTC, Youness Alaoui
committed Details | Review

Description Youness Alaoui 2017-11-03 18:31:24 UTC
Created attachment 362927 [details] [review]
rtpg722pay: Add encoding-params to the src caps template

The G722 payload only accepts G722 audio with channels=1, so it must
specify the encoding-params=1 in its src caps, otherwise it causes issues
with farstream which thinks it supports 2 channels G722 and when
confronted with a remote that has G722/8000/2, it will negotiate it
and error out with a not-negotiated when the caps don't intersect
at runtime.
Comment 1 Olivier Crête 2017-11-03 21:21:20 UTC
Merged

commit 593615de46a98165ff34e74bb2559eeecec61fec (HEAD -> master, upstream/master)
Author: Youness Alaoui <kakaroto@kakaroto.homelinux.net>
Date:   Fri Nov 3 13:27:50 2017 -0400

    rtpg722pay: Add encoding-params to the src caps template
    
    The G722 payload only accepts G722 audio with channels=1, so it must
    specify the encoding-params=1 in its src caps, otherwise it causes issues
    with farstream which thinks it supports 2 channels G722 and when
    confronted with a remote that has G722/8000/2, it will negotiate it
    and error out with a not-negotiated when the caps don't intersect
    at runtime.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789878