After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789553 - Variants obtained from iterator being leaked
Variants obtained from iterator being leaked
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-27 11:13 UTC by Carlos Garnacho
Modified: 2017-10-27 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backends: Unref variants obtained from g_variant_iter_get_next_value() (1.44 KB, patch)
2017-10-27 11:14 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2017-10-27 11:13:36 UTC 
Stumbled on this while chasing some variant leaks I see on valgrind (apparently not the ones I were seeing though). The MetaMonitorManager leaks (logical) outputs variant representations when iterating through those.
Comment 1 Carlos Garnacho 2017-10-27 11:14:02 UTC 
Created attachment 362397 [details] [review]
backends: Unref variants obtained from g_variant_iter_get_next_value()

Those are being leaked.
Comment 2 Jonas Ådahl 2017-10-27 11:17:53 UTC 
Review of attachment 362397 [details] [review]:

lgtm.
Comment 3 Carlos Garnacho 2017-10-27 11:51:27 UTC 
Thanks! Pushed to master/gnome-3-26

Attachment 362397 [details] pushed as 89f5ca3 - backends: Unref variants obtained from g_variant_iter_get_next_value()