GNOME Bugzilla – Bug 789471
fdkaacenc fails to generate 7.1 sound
Last modified: 2017-10-25 14:28:48 UTC
Created attachment 362247 [details] aac sample generator The attached test program works for all supported channel configurations except for the 7.1 case: ./generate_multichannel_aac.py 8 0:00:00.030532631 1664 0x557393c872d0 WARN queue gstqueue.c:1577:gst_queue_loop:<queue1> error: Internal data stream error. 0:00:00.030542136 1664 0x557393c872d0 WARN queue gstqueue.c:1577:gst_queue_loop:<queue1> error: streaming stopped, reason not-negotiated (-4) I'm using arch linux libdfkaac, which is 0.1.5 and contains references to the 7.1 support. https://git.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/libfdk-aac
Created attachment 362263 [details] [review] fdkaacenc: check fdk-aac version in meson.build configure.ac used to set -DHAVE_FDK_AAC_0_1_4 , which enables 7.1 support.
Thanks for reporting this issue, I assume you were building with meson, in which case the attached patch fixes the following pipeline for me: gst-launch-1.0 audiotestsrc num-buffers=300 ! audioconvert ! audioresample ! audio/x-raw, channels=8 ! fdkaacenc ! mp4mux ! filesink location=8-channels.m4a
I think that archlinux is not building with meson: build() { cd fdk-aac ./autogen.sh ./configure \ --prefix='/usr' \ --disable-static make } https://git.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/libfdk-aac
Ooops sorry you mean gst-plugins-bad https://git.archlinux.org/svntogit/packages.git/plain/trunk/PKGBUILD?h=packages/gst-plugins-bad ./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libexecdir=/usr/lib \ --with-package-name="GStreamer Bad Plugins (Arch Linux)" \ --with-package-origin="https://www.archlinux.org/" \ --with-gtk=3.0 \ --enable-experimental --enable-gtk-doc --disable-static Not sure it's using meson either (is it ?)
Just tested the meson build, detection of the version works, but build still fails. $ meson .. ... Native dependency libopenjp2 found: YES 2.3.0 $ ninja ... FAILED: ext/openjpeg/gstopenjpeg@sha/gstopenjpegenc.c.o cc -Iext/openjpeg/gstopenjpeg@sha -Iext/openjpeg -I../ext/openjpeg -I. -I../ -Igst-libs -I../gst-libs -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/openjpeg-2.3 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -g -fPIC -pthread -DHAVE_CONFIG_H -DHAVE_OPENJPEG_2_2 -DHAVE_OPENJPEG_2_1 -MMD -MQ 'ext/openjpeg/gstopenjpeg@sha/gstopenjpegenc.c.o' -MF 'ext/openjpeg/gstopenjpeg@sha/gstopenjpegenc.c.o.d' -o 'ext/openjpeg/gstopenjpeg@sha/gstopenjpegenc.c.o' -c ../ext/openjpeg/gstopenjpegenc.c In file included from ../ext/openjpeg/gstopenjpegenc.h:28:0, from ../ext/openjpeg/gstopenjpegenc.c:27: ../ext/openjpeg/gstopenjpeg.h:42:12: erreur fatale: openjpeg-2.2/openjpeg.h : Aucun fichier ou dossier de ce type # include <openjpeg-2.2/openjpeg.h> ^~~~~~~~~~~~~~~~~~~~~~~~~
Sorry, wrong window...
(In reply to Florent Thiéry from comment #5) > Just tested the meson build, detection of the version works, but build still > fails. that last issue was fixed by https://bugzilla.gnome.org/show_bug.cgi?id=788703 The package definitions you linked indeed seem to build with autotools, would be interesting to know the output of configure, in particular that check: https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/configure.ac#n2398
configure: *** checking feature: fdkaac plugin *** configure: *** for plug-ins: fdkaac *** checking for FDK_AAC... yes configure: *** These plugins will be built: fdkaac Not seeing anything else
in configure.log: configure:43291: *** checking feature: fdkaac plugin *** configure:43295: *** for plug-ins: fdkaac *** configure:43339: checking for FDK_AAC configure:43347: $PKG_CONFIG --exists --print-errors "fdk-aac >= 0.1.4" configure:43350: $? = 0 configure:43365: $PKG_CONFIG --exists --print-errors "fdk-aac >= 0.1.4" configure:43368: $? = 0 configure:43548: result: yes configure:43568: *** These plugins will be built: fdkaac
As matthieu found out, a missing comma was breaking the version check
Created attachment 362271 [details] [review] configure.ac patch to fix typo in fdkaac check
After patching configure.ac, fdkaacenc accepts producing 7.1 sounds.
Comment on attachment 362263 [details] [review] fdkaacenc: check fdk-aac version in meson.build Attachment 362263 [details] pushed as 2bf57a9 - fdkaacenc: check fdk-aac version in meson.build
Review of attachment 362271 [details] [review]: committed