After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789458 - gst-plugins-base: gstaudiochannels: Handled buffer mapping failure
gst-plugins-base: gstaudiochannels: Handled buffer mapping failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.12.3
Other All
: Normal minor
: 1.12.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-25 07:23 UTC by Ashish Kumar
Modified: 2017-10-25 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] gst-plugins-base: gstaudiochannels: Handled buffer mapping failure (1.03 KB, patch)
2017-10-25 07:25 UTC, Ashish Kumar 		committed Details | Review

Description Ashish Kumar 2017-10-25 07:23:54 UTC 
Buffer mapping failure must be handled at below code:-
File: gst-plugins-base-1.12.3/gst-libs/gst/audio/audio-channels.c
Function: gst_audio_buffer_reorder_channels
...
  if (gst_audio_channel_positions_equal (from, to, channels))
    return TRUE;

  gst_buffer_map (buffer, &info, GST_MAP_READWRITE);

  ret =
      gst_audio_reorder_channels (info.data, info.size, format, channels, from,
      to);

  gst_buffer_unmap (buffer, &info);
...

Failure of function gst_buffer_map must be handled.
Comment 1 Ashish Kumar 2017-10-25 07:25:59 UTC 
Created attachment 362237 [details] [review]
[PATCH] gst-plugins-base: gstaudiochannels: Handled buffer mapping failure

Please review the patch attached to fix the issue and share your feedback.
Comment 2 Mathieu Duponchelle 2017-10-25 11:11:42 UTC 
Thanks, I backported the patch to the 1.12 branch as it is obviously correct. Out of curiosity, where was that function called from when you observed the issue? Is the FALSE return value appropriately handled there? Any idea why the buffer could not be mapped?