GNOME Bugzilla – Bug 789386
[Regression] Shortcut Ctrl-Shift-Esc stopped working
Last modified: 2017-11-11 08:27:20 UTC
Back on Gnome Shell 3.22, I had Ctrl-Shift-Esc set up as a global shortcut to start the system monitor. Yesterday I upgraded to 3.26, and I just noticed that this broke my shortcut -- it no longer worked. I tried to re-assign the shortcut, only to notice that now Ctrl-Shift-Esc is no longer accepted as a shortcut at all. ## Actual behavior Ctrl-Shift-Esc is no longer accepted as a shortcut. ## Expected behavior It should still be accepted.
Does it work if you assign the shortcut manually with the 'gsettings' tool instead of the UI? If yes, then this is a gnome-control-center issue, otherwise it's a bug in mutter ...
I still had the shortcut set from before the update, and it did not work. So I think the answer is "no". I could test again if you want, but which key do I have to set to which value with gsettings?
Isn't Ctrl-Shift-Esc the shortcut used by the shortcut inhibitation cancellation? I.e. if you change that to something else, then mutter shouldn't eat it.
I have no idea what shortcut inhibition cancellation is, and neither does Google. Searching for "inhibit" in the shortcut configuration dialog shows no result. How would I change that?
@post+gnome: What keyboard layout are you using? In case it is Neo2 or any other non-standard layout, you might be seeing https://bugzilla.gnome.org/show_bug.cgi?id=789300
I am switching between the German and the English layout. Nothing non-standard.
The restore-shortcuts keybinding is in the gsettings schema org.gnome.mutter.wayland.keybindings key restore-shortcuts
I am on X11, does that still apply?
Seems the keybinding is added unconditionally. Olivier, I guess we should only add the restore-shortcuts keybinding when not on plain X11?
Yes, but that wouldn't solve the problem for users switching between x11 and Wayland who may still end up with the same conflicting shortcuts? Shouldn't we add this shortcut to gnome-control-center, so the conflict could be avoided?
(In reply to Olivier Fourdan from comment #10) > Yes, but that wouldn't solve the problem for users switching between x11 and > Wayland who may still end up with the same conflicting shortcuts? That is indeed true. > > Shouldn't we add this shortcut to gnome-control-center, so the conflict > could be avoided? That would make sense too.
And maybe change the default to something <super> based, to indicate that it's a system shortcut - <super>Escape is currently available as far as I can see.
(In reply to Florian Müllner from comment #12) > And maybe change the default to something <super> based, to indicate that > it's a system shortcut - <super>Escape is currently available as far as I > can see. Oh, I never realized that Super was for system shortcuts, yet "ctrl-shift-esc" was free as well iirc so changing the default doesn't prevent potential conflicts with custom shortcuts :)
(In reply to Olivier Fourdan from comment #13) > (In reply to Florian Müllner from comment #12) > > And maybe change the default to something <super> based, to indicate that > > it's a system shortcut - <super>Escape is currently available as far as I > > can see. > > Oh, I never realized that Super was for system shortcuts There was an initiative a while ago: https://wiki.gnome.org/Design/OS/KeyboardShortcuts, in particular "The primary system modifier key should be <Super>" > so changing the default doesn't prevent potential conflicts > with custom shortcuts :) Of course not, I didn't mean to imply that it would.
*** Bug 789747 has been marked as a duplicate of this bug. ***
Created attachment 363325 [details] [review] [PATCH] wayland: Use Super+Escape to re-enable shortcuts Change the default key combo to re-enable normal keyboard shortcuts processing while a shortcut inhibitor is in effect to Super+Escape as primary system modifier key should be Super. This should reduce the risk of potential conflict with other shortcuts. -- Note: I picked Super+Escape as this seem to be free and is simple enough, after checking that it was free from the list of default shortcuts: org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Home org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Page_Up org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Page_Down org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>End org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Above_Tab org.gnome.desktop.wm.keybindings.gschema.xml.in: <Shift><Super>Above_Tab org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Tab org.gnome.desktop.wm.keybindings.gschema.xml.in: <Shift><Super>Tab org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Up org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>Down org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>h org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Home org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>End org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Page_Up org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Page_Down org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Left org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Right org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Up org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super><Shift>Down org.gnome.desktop.wm.keybindings.gschema.xml.in: <Super>space org.gnome.desktop.wm.keybindings.gschema.xml.in: <Shift><Super>space org.gnome.desktop.wm.preferences.gschema.xml.in: <Super> and org.gnome.mutter.gschema.xml.in: Super_L org.gnome.mutter.gschema.xml.in: <Super>Left org.gnome.mutter.gschema.xml.in: <Super>Right org.gnome.mutter.gschema.xml.in: <Super>p
Created attachment 363327 [details] [review] [PATCH] Add restore-shortcuts to key bindings list gnome-control-center uses this to list the keybindings, without this users cannot change the default key combo to restore shortcuts.
Review of attachment 363325 [details] [review]: Makes sense to me
Review of attachment 363327 [details] [review]: LGTM (FWIW, I think more important than allowing users to change the shortcut is to make gnome-control-center aware of it so it can consider it for finding shortcut conflicts)
Thanks! While I was at it, I noticed that several other newly added shortcuts were missing, like the tiling shortcuts. Will post a separate bug for those.
Comment on attachment 363325 [details] [review] [PATCH] wayland: Use Super+Escape to re-enable shortcuts attachment 363325 [details] [review] pushed as commit 6c21a22 in git master - wayland: Use Super+Escape to re-enable shortcuts attachment 363325 [details] [review] pushed as commit 1d88288 in branch gnome-3-26 - wayland: Use Super+Escape to re-enable shortcuts
Comment on attachment 363327 [details] [review] [PATCH] Add restore-shortcuts to key bindings list attachment 363327 [details] [review] pushed to git master as commit 97635d6 - Add restore-shortcuts to key bindings list attachment 363327 [details] [review] pushed to branch gnome-3-26 as commit cc49f6e - Add restore-shortcuts to key bindings list
That's great, thanks :)