GNOME Bugzilla – Bug 789322
shell: Disable emoji chooser in main search box
Last modified: 2018-01-18 01:46:20 UTC
since none of our search panels or keywords contain emoji, it doesn't make sense to let people search for emoji What do you think about backporting this to gnome-3-26 too? It's not really required but as long as requiring gtk 3.22.20 is fine (released Sep 4 and in Ubuntu 17.10), then it shouldn't hurt either.
Created attachment 362057 [details] [review] shell: Disable emoji chooser in main search box
Review of attachment 362057 [details] [review]: not clear to me what's the value here. g-c-c has many entries where emoji aren't useful but I don't think they're harmful either and I don't think it makes sense to go around adding this property everywhere
In many of the other entry boxes, I am guessing you actually could use emoji if you really want to (hostname, Wi-Fi network name or password) but we know for a fact that none of the panels that will be returned by the search box will return any results for emoji characters. Therefore, this is a tiny detail that adds polish. This is based on similar commits done for gnome-tweak-tool and epiphany. I think we should check the Network panels too since Emoji are invalid input for MAC Address, Routes, DNS IP address.
Review of attachment 362057 [details] [review]: Small nitpick. ::: shell/window.ui @@ +30,3 @@ <property name="can_focus">True</property> <property name="width_chars">25</property> + <property name="input_hints">GTK_INPUT_HINT_NO_EMOJI</property> Would be better if it was just 'no-emoji'
Created attachment 366982 [details] [review] shell: Disable emoji chooser in main search box Update that.
Even if there is no hidden gold in this patch, it's one less annoying misbehavior to deal with. Thanks for your patch. Attachment 366982 [details] pushed as d4c4070 - shell: Disable emoji chooser in main search box