After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789146 - manifest: add build api patch to dconf
manifest: add build api patch to dconf
Status: RESOLVED OBSOLETE
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-10-18 13:00 UTC by Iñigo Martínez
Modified: 2017-10-18 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add build api patch for dconf (7.46 KB, patch)
2017-10-18 13:00 UTC, Iñigo Martínez
rejected Details | Review

Description Iñigo Martínez 2017-10-18 13:00:17 UTC
Created attachment 361802 [details] [review]
Add build api patch for dconf

dconf has recently moved to meson[0] and has also removed autotools[1] from its source code tree.

This patch adds a build api patch for it.

[0] https://git.gnome.org/browse/dconf/commit/?id=f7a71bd
[1] https://git.gnome.org/browse/dconf/commit/?id=5ec00d6
Comment 1 Iñigo Martínez 2017-10-18 13:12:17 UTC
I would like to point out that this patch includes a slightly different `configure` script, which also supports string based options.

A subset of these string based options are used for paths, and these are supported following the `--with-%option[=]$path` pattern.

I've also been considering rewriting the script in python, since there has to be python binary in the system for meson, to be used as a template for applications that are moving to meson. However I don't know if it would be worth enough.
Comment 2 Emmanuele Bassi (:ebassi) 2017-10-18 13:38:43 UTC
Review of attachment 361802 [details] [review]:

I appreciate the effort, but I don't think it's necessary.

Continuous just disables man pages/documentation, and doesn't need anything else.
Comment 3 Emmanuele Bassi (:ebassi) 2017-10-18 13:40:44 UTC
I've already committed a patch that deals with the transition, so I consider this obsolete.

(In reply to Iñigo Martínez from comment #1)
 
> I've also been considering rewriting the script in python, since there has
> to be python binary in the system for meson, to be used as a template for
> applications that are moving to meson. However I don't know if it would be
> worth enough.

This would probably be interesting, but porting every single patch would probably be overkill. The idea is that the current implementation of Continuous is on its way out, replaced by a build system that understands Meson natively, so we wouldn't need the build-api wrappers any more.