After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789024 - Change gettext package
Change gettext package
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-10-15 18:49 UTC by Iñigo Martínez
Modified: 2017-11-29 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Change gettext package (2.44 KB, patch)
2017-10-15 18:52 UTC, Iñigo Martínez 		none Details | Review
Change gettext domain. (4.84 KB, patch)
2017-11-29 10:22 UTC, Arnaud B. 		none Details | Review

Description Iñigo Martínez 2017-10-15 18:49:50 UTC 
`dconf-editor` uses `dconf` as gettext package. In order to be coherent, it should use the same string used as the application name.
Comment 1 Iñigo Martínez 2017-10-15 18:52:09 UTC 
Created attachment 361631 [details] [review]
Change gettext package

This patch changes the gettext package to dconf-editor so that it is consistent
with the application name.
Comment 2 Iñigo Martínez 2017-10-15 18:55:43 UTC 
Regarding translations in the `po` directory, I haven't made any changes to translations files because I'm not sure if that should be made by translators themselves.

Please let me know if this patch should also change the translations files or not.
Comment 3 Piotr Drąg 2017-10-15 21:10:03 UTC 
(In reply to Iñigo Martínez from comment #2)
> Regarding translations in the `po` directory, I haven't made any changes to
> translations files because I'm not sure if that should be made by
> translators themselves.
> 
> Please let me know if this patch should also change the translations files
> or not.

No need for that, we’ll take care of it. :)
Comment 4 Arnaud B. 2017-11-29 10:22:13 UTC 
Created attachment 364613 [details] [review]
Change gettext domain.

Piotr Drąg, does that patch look good for you? Can I push it?
Comment 5 Piotr Drąg 2017-11-29 15:51:36 UTC 
Looks good, as long as it still works.
Comment 6 Arnaud B. 2017-11-29 16:37:21 UTC 
Good philosophy. I pushed, let’s see what happens now.

Thanks both for your help. :)