Created attachment 361586 [details] [review]
build: Use subdir-objects with Autotools

We're eventually going to drop Autotools, but in the meantime we should
probably use idiomatic options and reduce warnings.

GLib is pretty much already safe for subdir-objects to be enabled,
except in the GIO tests, where the build references files that are
generated in a different level. For that, we can use the same solution
employed by GTK+, and link the appropriate file in the right
sub-directory.

Review of attachment 361586 [details] [review]:

This is horrific and evil and I bet you’re just doing it to make Meson look even better.

a_c-n if distcheck still passes and it still builds with srcdir ≠ builddir.

(In reply to Philip Withnall from comment #2)
> Review of attachment 361586 [details] [review] [review]:
> 
> This is horrific and evil and I bet you’re just doing it to make Meson look
> even better.

That's purely a side-effect of just how broken Autotools really are.

> a_c-n if distcheck still passes and it still builds with srcdir ≠ builddir.

I always do non-srcdir builds, and I verified that srcdir builds are working; I need to do a distcheck, though, just to be on the safe side.

(In reply to Emmanuele Bassi (:ebassi) from comment #3)
> I need to do a distcheck, though, just to be on the safe side.

Any progress on that?

Sorry, lost track of this. Will run a distcheck.

The distcheck failed inside a gschema compilation test, but that happens to me without the patch as well, so I think it's another issue entirely.

The build and tests associated to this patch succeeded.

Let’s push this then.

Attachment 361586 [details] pushed as 5c13bf9 - build: Use subdir-objects with Autotools