Created attachment 361423 [details] [review]
gunixmounts: Update list of virtual file systems to ignore

Synchronise it with the list in gnome-settings-daemon, which has seen
more recent updates than this one.

https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/housekeeping/gsd-disk-space-helper.c

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Could we not have this data in a shared header in GIO instead?

(make that gio-unix)

Hmm. I’d rather not expose the actual list of strings in a header, because that ties the check to being non-programmatic. Ideally we’d have an API like g_unix_mount_is_system_internal(), but which doesn’t factor in the result of g_unix_is_mount_path_system_internal() since that’s irrelevant in g-s-d’s case.

g_unix_mount_has_system_fs_type()?
and g_unix_mount_has_system_device_path()?

I’d like to handle that as a follow-up bug in any case, though, since I’d like to get this particular fix in now so we can carry it downstream without problems.

Review of attachment 361423 [details] [review]:

The list makes sense to me... those filesystems (at least those which I know) are usually used in system paths anyway or are problematic for various reasons (and those which I don't know are definitely system internal :-). And we have x-gvfs-show for sure...

And it is definitely a good idea to share this somehow. GVfs currently uses just g_unix_is_mount_path_system_internal, but it would probably be a good idea to check also other indications...

Thanks for the review, Ondrej. I’ll push this and have filed bug #788927 about reducing the duplication between GLib, g-s-d and g-c-c.

Attachment 361423 [details] pushed as 0d69462 - gunixmounts: Update list of virtual file systems to ignore