After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788780 - decklink: Print one "dropped N old frames" message, not one per frame
decklink: Print one "dropped N old frames" message, not one per frame
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-10 15:05 UTC by Vivia Nikolaidou
Modified: 2017-10-11 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decklink: Print one "dropped N old frames" message, not one per frame (3.93 KB, patch)
2017-10-10 15:05 UTC, Vivia Nikolaidou 		none Details | Review
decklink: Print one "dropped N old frames" message, not one per frame (3.31 KB, patch)
2017-10-11 09:09 UTC, Vivia Nikolaidou 		committed Details | Review

Description Vivia Nikolaidou 2017-10-10 15:05:06 UTC 
See commit message
Comment 1 Vivia Nikolaidou 2017-10-10 15:05:10 UTC 
Created attachment 361251 [details] [review]
decklink: Print one "dropped N old frames" message, not one per frame

If we drop many frames at once, printing one message per video frame and
one per audio packet would cause a lot of disk IO. Just print a total at
the end.
Comment 2 Sebastian Dröge (slomo) 2017-10-10 15:19:22 UTC 
Comment on attachment 361251 [details] [review]
decklink: Print one "dropped N old frames" message, not one per frame

Looks good but depends on your QoS patch
Comment 3 Vivia Nikolaidou 2017-10-11 09:09:36 UTC 
Created attachment 361304 [details] [review]
decklink: Print one "dropped N old frames" message, not one per frame

If we drop many frames at once, printing one message per video frame and
one per audio packet would cause a lot of disk IO. Just print a total at
the end.
Comment 4 Vivia Nikolaidou 2017-10-11 09:14:54 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 361251 [details] [review] [review]
> decklink: Print one "dropped N old frames" message, not one per frame
> 
> Looks good but depends on your QoS patch

Sorry - it was just a whitespace diff that got accidentally committed.
Comment 5 Sebastian Dröge (slomo) 2017-10-11 16:30:27 UTC 
Attachment 361304 [details] pushed as 0355bb7 - decklink: Print one "dropped N old frames" message, not one per frame