After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788706 - fmradio: Fix build with GStreamer master
fmradio: Fix build with GStreamer master
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-09 11:15 UTC by Bastien Nocera
Modified: 2017-10-09 12:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fmradio: Fix build with GStreamer master (1.02 KB, patch)
2017-10-09 11:15 UTC, Bastien Nocera 		none Details | Review
fmradio: Fix build with GStreamer master (1.17 KB, patch)
2017-10-09 12:08 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-10-09 11:15:31 UTC 
.
Comment 1 Bastien Nocera 2017-10-09 11:15:35 UTC 
Created attachment 361175 [details] [review]
fmradio: Fix build with GStreamer master

The plugin description is not supposed to be a string constant, but an
unescaped string, to be concatenated with function names.

This used to be acceptable (though would have warned), but breaks with
the GStreamer 1.13 development branch.
Comment 2 Jonathan Matthew 2017-10-09 11:46:38 UTC 
Review of attachment 361175 [details] [review]:

I don't think I've seen any warnings about it, but this is obviously correct.
Comment 3 Bastien Nocera 2017-10-09 12:08:26 UTC 
Created attachment 361178 [details] [review]
fmradio: Fix build with GStreamer master

The plugin description is not supposed to be a string constant, but an
unescaped string, to be concatenated with function names.

This used to be acceptable (though would have warned), but breaks with
the GStreamer 1.13 development branch.

rb-fm-radio-gst-src.c:181:6: error: pasting ""rbsilencesrc"" and "_get_desc" does not give a valid preprocessing token
      "rbsilencesrc",
      ^
Comment 4 Bastien Nocera 2017-10-09 12:09:22 UTC 
Attachment 361178 [details] pushed as b182c6b - fmradio: Fix build with GStreamer master