After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788705 - Allow building GLib on older Linux platforms
Allow building GLib on older Linux platforms
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-10-09 10:52 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-10-09 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Look for mkostemp when configuring (2.17 KB, patch)
2017-10-09 10:52 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
Do not build journal integration on older Linux platforms (1.82 KB, patch)
2017-10-09 10:52 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2017-10-09 10:52:19 UTC 
In order to build the journal integration for the logging API, we depend on mkostemp() and O_CLOEXEC. These two features may not be available on older Linux systems.

Since the journal integration is already optional, we can easily avoid build failures when compiling a newer version of GLib on those older systems.
Comment 1 Emmanuele Bassi (:ebassi) 2017-10-09 10:52:23 UTC 
Created attachment 361173 [details] [review]
build: Look for mkostemp when configuring

We use this function, but it may be missing on older Linux platforms.
Comment 2 Emmanuele Bassi (:ebassi) 2017-10-09 10:52:27 UTC 
Created attachment 361174 [details] [review]
Do not build journal integration on older Linux platforms

We need to add more checks for journal_sendv(), as we depend on the
presence of mkostemp() and O_CLOEXEC, which may not be available on
older Linux platforms, like RHEL 5.
Comment 3 Philip Withnall 2017-10-09 11:11:53 UTC 
Review of attachment 361173 [details] [review]:

Yes.
Comment 4 Philip Withnall 2017-10-09 11:12:29 UTC 
Review of attachment 361174 [details] [review]:

Yes.
Comment 5 Emmanuele Bassi (:ebassi) 2017-10-09 11:46:29 UTC 
Attachment 361173 [details] pushed as f40154e - build: Look for mkostemp when configuring
Attachment 361174 [details] pushed as dc39232 - Do not build journal integration on older Linux platforms