After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788703 - openjpeg: Fix build against openjpeg 2.3
openjpeg: Fix build against openjpeg 2.3
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.12.x
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 789481 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-10-09 10:22 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-10-25 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] openjpeg: Fix build against openjpeg 2.3 (1.03 KB, patch)
2017-10-09 10:22 UTC, Jan Alexander Steffens (heftig) 		none Details | Review
[PATCH 1/2] Revert "openjpeg: Support building with openjpeg 2.3" (3.04 KB, patch)
2017-10-19 15:12 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
[PATCH 2/2] openjpeg: Support building with openjpeg 2.3, simpler (3.40 KB, patch)
2017-10-19 15:15 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
[PATCH] openjpeg: Remove compatibility with openjpeg 2.0 (4.58 KB, patch)
2017-10-20 10:01 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2017-10-09 10:22:49 UTC 
Created attachment 361171 [details] [review]
[PATCH] openjpeg: Fix build against openjpeg 2.3

OpenJPEG 2.3 installs its headers to /usr/include/openjpeg-2.3. However,
since libopenjp2.pc seems to provide the right includedir CFLAGS at
least since version 2.2, instead of adding yet another version check,
just remove the subdir.
Comment 1 Andreas Frisch 2017-10-19 08:02:09 UTC 
Review of attachment 361171 [details] [review]:

works for me!
Comment 2 Sebastian Dröge (slomo) 2017-10-19 13:29:12 UTC 
Comment on attachment 361171 [details] [review]
[PATCH] openjpeg: Fix build against openjpeg 2.3

Please update this to latest GIT and remove all the configure checks for different 2.x versions, and also update the meson.build
Comment 3 Jan Alexander Steffens (heftig) 2017-10-19 13:34:07 UTC 
I'm not sure 2.1 and earlier set the CFLAGS correctly.
Comment 4 Sebastian Dröge (slomo) 2017-10-19 13:50:34 UTC 
Can you check and update accordingly?
Comment 5 Jan Alexander Steffens (heftig) 2017-10-19 15:12:14 UTC 
Created attachment 361884 [details] [review]
[PATCH 1/2] Revert "openjpeg: Support building with openjpeg 2.3"

This reverts commit ef4d6b93e6078b7056c51a928f5620b13e55e323.

A better fix follows.
Comment 6 Jan Alexander Steffens (heftig) 2017-10-19 15:15:10 UTC 
Created attachment 361885 [details] [review]
[PATCH 2/2] openjpeg: Support building with openjpeg 2.3, simpler

OpenJPEG 2.3 installs its headers to /usr/include/openjpeg-2.3. However,
since libopenjp2.pc seems to provide the right includedir CFLAGS at
least since version 2.1, instead of adding yet another version check,
just remove the subdir and the check for 2.2.
Comment 7 Jan Alexander Steffens (heftig) 2017-10-20 10:01:33 UTC 
Created attachment 361923 [details] [review]
[PATCH] openjpeg: Remove compatibility with openjpeg 2.0

And another one on top, if you want to simplify things further.

Everyone seems to be shipping 2.1 as the oldest v2 version, even debian
oldstable (jessie).

Also remove an unneeded (debug?) #include <stdio.h>.
Comment 8 Sebastian Dröge (slomo) 2017-10-25 13:28:05 UTC 
*** Bug 789481 has been marked as a duplicate of this bug. ***