After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788385 - gtestutils: Explicitly cast args to g_assertion_message_cmpnum()
gtestutils: Explicitly cast args to g_assertion_message_cmpnum()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-09-30 23:50 UTC by Philip Withnall
Modified: 2017-10-02 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtestutils: Explicitly cast args to g_assertion_message_cmpnum() (4.50 KB, patch)
2017-09-30 23:50 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-09-30 23:50:37 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-09-30 23:50:43 UTC 
Created attachment 360711 [details] [review]
gtestutils: Explicitly cast args to g_assertion_message_cmpnum()

This avoids warnings when compiling with -Wconversion on 32-bit
architectures, as the conversion to (long double) is not necessarily
lossless. We don’t care about that, though, since the actual comparison
was done with the correct types, and g_assertion_message_cmpnum() is
only used to print failure information.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Matthias Clasen 2017-10-02 14:28:06 UTC 
Review of attachment 360711 [details] [review]:

ok
Comment 3 Philip Withnall 2017-10-02 14:33:09 UTC 
Attachment 360711 [details] pushed as 702b6af - gtestutils: Explicitly cast args to g_assertion_message_cmpnum()