GNOME Bugzilla – Bug 788272
[PATCH] Remember active view type(icon/list)
Last modified: 2017-12-11 13:50:36 UTC
Currently the default view is icon view. If a user switch to list view, close Bijiben and open it again, it'll switch back to the default icon view instead of the active one when users close Bijiben. It'll be nice if the active view type can be saved and loaded when bijiben starts.
Created attachment 360578 [details] [review] main-view: Remember active view type Save the active view type and load it when bijiben starts, so the user is presented with the last visible state of Bijiben when he/she last used it.
Review of attachment 360578 [details] [review]: Hi Jonathan, thanks for your patch, but it's using autotools and now we're using meson, so please update your patch. I appreciate and I'm sorry for taking this long to review it!
Created attachment 364103 [details] [review] main-view: Remember active view type patch rebased.
Review of attachment 364103 [details] [review]: Got an error when trying to install: $ LANG=C sudo ninja install ... Compile gsettings schemas... /usr/local/share/glib-2.0/schemas/org.gnome.bijiben.gschema.xml:38:1 Error on line 38 char 1: <enum id='org.gnome.bijiben.GdMainViewType'> not (yet) defined.. This entire file has been ignored. ...
Created attachment 364656 [details] [review] main-view: Remember active view type Patch updated. Add needed build target in data/meson.build.
Review of attachment 364656 [details] [review]: Still not good: $ ninja ninja: error: '../libgd/libgd/gd-main-view.h', needed by 'data/org.gnome.bijiben.enums.xml', missing and no known rule to make it
(In reply to Isaque Galdino from comment #6) > Review of attachment 364656 [details] [review] [review]: > > Still not good: > $ ninja > ninja: error: '../libgd/libgd/gd-main-view.h', needed by > 'data/org.gnome.bijiben.enums.xml', missing and no known rule to make it Could you please show me your steps to build bijiben? Everything works well here. Both using > jhbuild buildone -n bijiben (I've changed jhbuild source code to use meson) and > mkdir builddir && meson builddir && cd builddir && ninja
You might have old files in your setup. This is the correct file path: - input: '../libgd/libgd/gd-main-view.h', + input: '../subprojects/libgd/libgd/gd-main-view.h', Thanks.
Created attachment 364983 [details] [review] main-view: Remember active view type (In reply to Isaque Galdino from comment #8) > You might have old files in your setup. This is the correct file path: > - input: '../libgd/libgd/gd-main-view.h', > + input: '../subprojects/libgd/libgd/gd-main-view.h', > Ah, I forgot to delete the old libgd directory. It should work this time.
Review of attachment 364983 [details] [review]: Thanks for you patch!