After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788265 - notification icon too small on high resolution displays
notification icon too small on high resolution displays
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-28 03:04 UTC by ed.bruck1
Modified: 2017-09-29 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Default message icon size of 16x16 (44.07 KB, image/png)
2017-09-28 19:21 UTC, ed.bruck1
  Details
Patched calendar.js with message icon size of 48px (47.50 KB, image/png)
2017-09-28 19:23 UTC, ed.bruck1
  Details
calendar: Make notification icons font-relative (2.90 KB, patch)
2017-09-29 13:12 UTC, Florian Müllner
committed Details | Review
Example of too small for non-svg images. (7.39 KB, image/png)
2017-09-29 15:28 UTC, ed.bruck1
  Details

Description ed.bruck1 2017-09-28 03:04:15 UTC
The changes made for this bug (https://bugzilla.gnome.org/show_bug.cgi?id=775763) has resulted in an icon size of 16 pixels for notification messages. On higher resolution displays the icon is very small and simply ugly.

I have found that I can patch libgnome-shell.so to adjust the size for my 2K & 4K systems. It would be nice if the size could be adjusted through an extension or perhaps set via a theme.
Comment 1 Florian Müllner 2017-09-28 14:42:22 UTC
Do you mean the icon is not scaled properly on HiDPI systems? Or do you simply disagree with the smaller size in the updated design?
Comment 2 ed.bruck1 2017-09-28 16:52:32 UTC
I've tried scaling my fonts on a 4K display to 1.30 and a two line message is larger, but the icon is still very small. I am the author of radiotray-ng and I like to use images for my station notifications. I did briefly try HiDPI (non-fractional) scaling and it is larger so that is working as expected.

To me it seems the icon should scale up to the height of the message as much as it can while maintaining its aspect ratio.
Comment 3 ed.bruck1 2017-09-28 19:21:13 UTC
Created attachment 360627 [details]
Default message icon size of 16x16
Comment 4 ed.bruck1 2017-09-28 19:23:08 UTC
Created attachment 360628 [details]
Patched calendar.js with message icon size of 48px
Comment 5 ed.bruck1 2017-09-28 19:23:29 UTC
I've attached two examples taken from a 4K system.
Comment 6 Florian Müllner 2017-09-29 13:12:53 UTC
Created attachment 360664 [details] [review]
calendar: Make notification icons font-relative

So not really a bug, but disagreement with a particular design decision - for what it's worth, your screenshot doesn't look "very small and simply ugly" to me at all. I'm not going to revert that change, but I think it makes sense for the icon to follow the text scaling. Incidentally, that change will make it possible for themes to override the icon size (if they must).
Comment 7 Rui Matos 2017-09-29 13:20:35 UTC
Review of attachment 360664 [details] [review]:

sure

::: data/theme/gnome-shell.css
@@ +922,2 @@
   .message-icon-bin:rtl {
+    padding: 0.68em 0.68em 0.68em 0.2em; }

just curious, how did you get at these numbers?
Comment 8 Florian Müllner 2017-09-29 13:56:48 UTC
(In reply to Rui Matos from comment #7)
> just curious, how did you get at these numbers?

The default font size in the CSS is 11pt. At the default 96 DPI, that's 11*96/72 px (14 2/3) - and what other pixel values needs to be divided by to translate to em.
Comment 9 Florian Müllner 2017-09-29 13:59:35 UTC
Attachment 360664 [details] pushed as 3eb80dc - calendar: Make notification icons font-relative
Comment 10 ed.bruck1 2017-09-29 15:27:06 UTC
I should not have said "ugly". I'll attach an example of what I mean about "fuzzy". The choice of 16px is just too small for anything other than SVG images of symbols such as close/info etc.
Comment 11 ed.bruck1 2017-09-29 15:28:28 UTC
Created attachment 360674 [details]
Example of too small for non-svg images.

There is plenty of room to expand the icon. Hopefully the changes made will address this.