GNOME Bugzilla – Bug 788155
Use g_auto to reduce memory leaks
Last modified: 2021-06-09 16:25:10 UTC
Created attachment 360380 [details] [review] background: Use g_auto for variables Use the g_auto macros to reduce memory leaks. There were a couple found making this patch.
Created attachment 360387 [details] [review] background: Use g_auto for variables Missed some g_strfreev.
Any chance of a review?
(In reply to Robert Ancell from comment #2) > Any chance of a review? I'd be happy to review and accept this patches, but it seems to me that we adopted in g-c-c a policy of only using g_auto in newly introduced code, and not porting old stuff yet. Point me out if I'm wrong.
I asked on the mailing list and the only request was they were reviewed in Bugzilla: https://mail.gnome.org/archives/gnomecc-list/2017-September/msg00005.html Not sure if there's been another discussion otherwise.
(In reply to Robert Ancell from comment #4) > I asked on the mailing list and the only request was they were reviewed in > Bugzilla: > https://mail.gnome.org/archives/gnomecc-list/2017-September/msg00005.html > > Not sure if there's been another discussion otherwise. Ah, great! In this case I will valgrind it a bit and get back to you soon. Thanks for your patch!
Review of attachment 360387 [details] [review]: Thanks Robert! Sadly, the patch doesn't apply on current master due to a conflict in panels/background/cc-background-panel.c. Would it be possible for you to rebase it? Otherwise, I can do it myself. Note that the Backgrounds panel is being redesigned (bug 788515), but I also don't want to just throw away your patch since you obviously spent some effort here.
Created attachment 366477 [details] [review] background: Use g_auto for variables Rebased to master.
Review of attachment 366477 [details] [review]: Hi Robert, thanks for your patch. The Background panel is going through a major rework, and I'm afraid merging this patch would add more burden than we'd gain from it. As such, I'll close this bug and mark this patch as obsolete. I am sorry to loose your work like this, and hope you understand the rationale behind the decision.
Review of attachment 366477 [details] [review]: Actually, I'll step back from my previous decision, and will apply your patch. Thanks for taking the time to work on it.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.