Created attachment 360377 [details] [review]
plugin: API: GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_RELATIVE_TO_EXE

Review of attachment 360377 [details] [review]:

Generally looks good to me, just some cosmetics.

::: gst/gst.c
@@ +363,3 @@
+find_executable_path (void)
+{
+}

Might want to do a GST_FIXME() here.

::: gst/gstplugin.c
@@ +1726,3 @@
+      if (paths_are_relative_to_exe && !g_path_is_absolute (path)) {
+        if (!_gst_executable_path) {
+          GST_LOG_OBJECT (plugin,

GST_FIXME

Is it a contest to make the longest symbol in Gst ? Maybe GST_PLUGIN_DEPENDENCY_FLAG_EXE_RELATIVE_PATHS ?

Created attachment 360384 [details] [review]
plugin: API: GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_RELATIVE_TO_EXE

When a plugin declares a dependency using this flag, all the
relative paths are considered to be relative to the path of
the main executable.

We try to determine the path of the executable portably,
with implementations provided for Linux, Windows and Mac.

If retrieval of the path fails, we will not detect changes.

In order for the main executable path to be the same when
scanning a plugin in a child process, a new variable is
exposed in gst_private.h, _gst_executable_path

I'm sure this doesn't even come close to the longest we have ;)

It's not even a symbol in any of our libraries. I think the longest ones are still in the MXF plugin.

In any case, I'm fine with whatever name as long as it's descriptive.

(In reply to Nicolas Dufresne (stormer) from comment #3)
> Is it a contest to make the longest symbol in Gst ? Maybe
> GST_PLUGIN_DEPENDENCY_FLAG_EXE_RELATIVE_PATHS ?

I would have done something like that were it not for consistency, ended up using this scheme as we also have GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_DEFAULT_ONLY :)

Attachment 360384 [details] pushed as 6cddce7 - plugin: API: GST_PLUGIN_DEPENDENCY_FLAG_PATHS_ARE_RELATIVE_TO_EXE

(In reply to Mathieu Duponchelle from comment #7)
> (In reply to Nicolas Dufresne (stormer) from comment #3)
> > Is it a contest to make the longest symbol in Gst ? Maybe
> > GST_PLUGIN_DEPENDENCY_FLAG_EXE_RELATIVE_PATHS ?

Make sense, thanks.