After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788129 - [PATCH] CssSelectorParser : fix attribute parsing.
[PATCH] CssSelectorParser : fix attribute parsing.
Status: RESOLVED FIXED
Product: gxml
Classification: Other
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: GXml maintainer(s)
GXml maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-25 12:57 UTC by Yannick Inizan
Modified: 2017-09-29 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] CssSelectorParser : fix attribute parsing. (3.33 KB, patch)
2017-09-25 12:57 UTC, Yannick Inizan 		none Details | Review
[PATCH] CssSelectorParser : fix attribute parsing. (15.67 KB, patch)
2017-09-26 02:13 UTC, Yannick Inizan 		committed Details | Review

Description Yannick Inizan 2017-09-25 12:57:59 UTC 
Created attachment 360350 [details] [review]
[PATCH] CssSelectorParser : fix attribute parsing.

current parsing omit '-' in attribute name.
all characters inside quotes are allowed. only un-quoted strings are analyzed.
Comment 1 Yannick Inizan 2017-09-26 02:13:18 UTC 
Created attachment 360395 [details] [review]
[PATCH] CssSelectorParser : fix attribute parsing.

add 'attribute-value-unquoted' test case.
Comment 2 Daniel Espinosa 2017-09-29 16:28:19 UTC 
Review of attachment 360395 [details] [review]:

Your work have been pushed:

https://git.gnome.org/browse/gxml/commit/?id=a93bd5b35b4b5c0492f3579b67213dac2a633f2c

Thanks for your great effort in GXml improvement. Hope you can push multiple selector support and all CSS3 selectors support.