After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788041 - deinterlace: Fixed memory leak in error code path.
deinterlace: Fixed memory leak in error code path.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-22 10:21 UTC by DEEPAK SRIVASTAVA
Modified: 2017-09-22 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PatchFile (831 bytes, patch)
2017-09-22 10:23 UTC, DEEPAK SRIVASTAVA 		needs-work Details | Review
updatedPatch (1.17 KB, patch)
2017-09-22 11:28 UTC, DEEPAK SRIVASTAVA 		committed Details | Review

Description DEEPAK SRIVASTAVA 2017-09-22 10:21:09 UTC 
Fixed memory leak in error code path in gst_deinterlace_setcaps().
Patch file is attached.
Please provide the feedback.
Comment 1 DEEPAK SRIVASTAVA 2017-09-22 10:23:00 UTC 
Created attachment 360249 [details] [review]
PatchFile
Comment 2 Sebastian Dröge (slomo) 2017-09-22 11:00:00 UTC 
Review of attachment 360249 [details] [review]:

Thanks for the patch, it's correct. But while we're at it, some other minor cleanup can also be done:

::: gst/deinterlace/gstdeinterlace.c
@@ +2814,2 @@
     if (srccaps)
       gst_caps_unref (srccaps);

srccaps are always not NULL here and in the set_caps_failed case
Comment 3 DEEPAK SRIVASTAVA 2017-09-22 11:28:57 UTC 
Created attachment 360254 [details] [review]
updatedPatch

Review comments updated.
Comment 4 Sebastian Dröge (slomo) 2017-09-22 14:27:12 UTC 
commit 49ed67c4f23e4d494f52147c07c447eff61a6ef0 (HEAD -> master)
Author: Deepak Srivastava <srivastava.d@samsung.com>
Date:   Fri Sep 22 16:55:21 2017 +0530

    deinterlace: Fixed memory leak in error code path
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788041