GNOME Bugzilla – Bug 788007
Remove minor bits of legacy from DMRaid module
Last modified: 2017-10-10 17:24:30 UTC
Patchset to follow
Created attachment 360215 [details] [review] Remove minor bits of legacy from DMRaid module (v1) Hi Curtis, Here's the patchset for this. Please check my understanding is correct and in patch number 1 the second sentence of the comment should be removed too. Sentence 1 being kept: Newer dmraid defaults to always inserting the letter 'p' between the device name and the partition number. Sentence 2 being removed: Since the '-P' option is not valid for older dmraid versions, try with and without the '-P' option. Thanks, Mike
Hi Mike, Your understanding of the dmraid '-P' option is correct and your changes look good to me. Do you have more enhancements that should be included for the next GParted release, or should we think about another GParted release soon with what we currently have (perhaps early October)? Do you have more edits planned for the GParted Manual? Before the next GParted release I think we should also update additional metadata in the GParted Manual, such as the appversion, manrevision, date, and revhistory. I can add this to this patch set if we plan to release GParted soon. Curtis
Hi Curtis, In reverse order ... No I don't have any more edits planned for the GParted Manual. Go ahead and add a patch to update the metadata in preparation for the next release. A release in early October would be only 2 months after the last one. I don't mind, just curious, was there some external reason for this? I do have a bit of a refactoring in the works to do with partition types and the whole disk flag as stored in the Partition class. No user visible changes from this. There is no reason to delay the release to have this land first. Either it makes it in time or it doesn't. Probably won't. Mike
Hi Mike, No real driver from me for making a release in October. In the past we've made a release every 2-3 months, but that has slowed down as of late. I just thought it might be good to get the new Wayland support out there so that Packagers have more time to get it ready for upcoming distro releases. Curtis
Thank you Mike for cleaning up no-longer needed legacy portions of the DMRaid code and for enhancing the help manual. Patch set v1 from comment #1 has been committed to the git repository, along with a patch to convert help manual links to HTTPS and update the version. The relevant git commits can be viewed at the following links: Remove backward compatibility for dmraid without -P option (#788007) https://git.gnome.org/browse/gparted/commit/?id=a89d55a6f0a8886843ba89872ef447ca38ab2be6 Stop nicing external commands run by the DMRaid module (#788007) https://git.gnome.org/browse/gparted/commit/?id=25d2aa341c9887d9d5fa0ca6ace6e583f23b651d Pass string literals directly to execute_command() https://git.gnome.org/browse/gparted/commit/?id=f5d3f97c7a6af17c82485616f6bf073c8e64b2c6 Describe Create New Partition / Partition name field in the Manual https://git.gnome.org/browse/gparted/commit/?id=a2d54df7494b1c4a2de0e9991a9ace5b40126f20 Convert Manual links to HTTPS where possible and update version https://git.gnome.org/browse/gparted/commit/?id=a8172ecb04afabd636e3ad3d6f6665af894516f1 Curtis
This enhancement was included in the GParted 0.30.0 release on October 10, 2017.