After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787985 - webpenc: fix unmap video frame in failed case
webpenc: fix unmap video frame in failed case
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.13.x
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-21 12:51 UTC by Ponnam Srinivas
Modified: 2017-09-23 08:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch file attached (1.05 KB, patch)
2017-09-21 12:51 UTC, Ponnam Srinivas
committed Details | Review

Description Ponnam Srinivas 2017-09-21 12:51:39 UTC
Created attachment 360192 [details] [review]
patch file attached

Hi ,
 In gst_webp_enc_handle_frame, missed Unmap video frame in failed case
 
 code:
 if (WebPEncode (&enc->webp_config, &enc->webp_picture)) {
    WebPPictureFree (&enc->webp_picture);

    out_buffer = gst_buffer_new_allocate (NULL, enc->webp_writer.size, NULL);
    if (!out_buffer) {
      GST_ERROR_OBJECT (enc, "Failed to create output buffer");
      return GST_FLOW_ERROR;
    }
    gst_buffer_fill (out_buffer, 0, enc->webp_writer.mem,
        enc->webp_writer.size);
    free (enc->webp_writer.mem);
  } else {
    GST_ERROR_OBJECT (enc, "Failed to encode WebPPicture");
    return GST_FLOW_ERROR;
  
  
  sol: gst_video_frame_unmap (&vframe); added 
  Patch attached. Please review and share feedback.
Comment 1 Ponnam Srinivas 2017-09-23 04:59:44 UTC
Patch attached. Please review and share feedback.
Comment 2 Tim-Philipp Müller 2017-09-23 08:08:45 UTC
Thanks.

commit d99cef0b409936219cc123d18e4a1da711c8362e (HEAD -> master)
Author: Ponnam Srinivas <p.srinivas@samsung.com>
Date:   Thu Sep 21 18:13:19 2017 +0530

    webpenc: Unmap video frame in failed case
    
    https://bugzilla.gnome.org/show_bug.cgi?id=787985