GNOME Bugzilla – Bug 787980
tests: ipcpipeline: fix struct initializations
Last modified: 2018-01-17 12:08:17 UTC
See commit description
Created attachment 360175 [details] [review] tests: ipcpipeline: fix struct initializations When compiling with clang 3.8.1 (debian) an error shows up: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] This patch fix structures initialization adding the missing braces. Nonetheless, this patch has to be committed with --no-verify because this changeset is not well handled by gst-indent.
> This patch fix structures initialization adding the missing braces. > Nonetheless, this patch has to be committed with --no-verify because > this changeset is not well handled by gst-indent. That's not good, will just cause problems next time someone makes a change to the file. It might make sense to define FOO_INIT macros that can be used like foo_t f = FOO_INIT; and that would probably also play nice with gst-indent.
Pushed this now: commit e62eb34bfc08115c8125355152f55436ea6db506 (HEAD -> master) Author: Tim-Philipp Müller <tim@centricular.com> Date: Wed Jan 17 12:06:28 2018 +0000 tests: ipcpipeline: fix struct initialisation warnings with clang Use init macros to avoid gst-indent making a mess of it. https://bugzilla.gnome.org/show_bug.cgi?id=787980 Didn't test with clang, so if it's still a problem please push a fix for the init macros.