After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787950 - main: don't override manager with NULL value
main: don't override manager with NULL value
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-20 16:53 UTC by Ray Strode [halfline]
Modified: 2017-09-20 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: don't override manager with NULL value (2.35 KB, patch)
2017-09-20 16:53 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2017-09-20 16:53:00 UTC 
on_bus_lost currently calls gsm_manager_set_phase (NULL, ...),
because a local is shadowing a global.

This commit fixes that.
Comment 1 Ray Strode [halfline] 2017-09-20 16:53:19 UTC 
Created attachment 360143 [details] [review]
main: don't override manager with NULL value
Comment 2 Ray Strode [halfline] 2017-09-20 17:20:12 UTC 
Attachment 360143 [details] pushed as 09d6022 - main: don't override manager with NULL value