After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787864 - Missing dependency for run-js-test in meson.build
Missing dependency for run-js-test in meson.build
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: building
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-18 23:11 UTC by Jan Tojnar
Modified: 2020-03-21 01:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch adding the gi dependency (914 bytes, patch)
2017-09-18 23:11 UTC, Jan Tojnar 		accepted-commit_now Details | Review

Description Jan Tojnar 2017-09-18 23:11:19 UTC 
Created attachment 360016 [details] [review]
Patch adding the gi dependency

run-js-test requires girepository.h header file which is provided by gobject-introspection. This dependency was not listed in meson build file.
Comment 1 Florian Müllner 2017-09-21 17:39:37 UTC 
Review of attachment 360016 [details] [review]:

The gjs dependency already brings in the required compiler/linker flags, but adding the dependency explicitly won't hurt (and is consistent with what we do for libshell) ...
Comment 2 Jan Tojnar 2020-03-21 01:51:29 UTC 
Moving to GitLab as it will just keep rotting here.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1114