After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787857 - Migrate from Intltool to Gettext
Migrate from Intltool to Gettext
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on: 787806
Blocks:
 
 
Reported: 2017-09-18 18:57 UTC by Iñigo Martínez
Modified: 2018-01-08 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Migrate from Intltool to Gettext (5.38 KB, patch)
2017-09-18 18:58 UTC, Iñigo Martínez 		none Details | Review
build: Migrate from Intltool to Gettext (5.77 KB, patch)
2017-11-17 12:29 UTC, Iñigo Martínez 		committed Details | Review

Description Iñigo Martínez 2017-09-18 18:57:06 UTC 
Recent versions of Gettext are able to translate several formats that are used in GNOME applications, so there is really no need anymore to use intltool or GLib’s dated gettext glue.
Comment 1 Iñigo Martínez 2017-09-18 18:58:18 UTC 
Created attachment 360010 [details] [review]
Migrate from Intltool to Gettext

This patch migrates translations from intltool to gettext. It depends on meson build port patch as it uses meson's i18n module.
Comment 2 Bastien Nocera 2017-11-17 11:56:43 UTC 
Review of attachment 360010 [details] [review]:

Can you also mention why you removed the "Icon=" line? Otherwise looks good.
Comment 3 Iñigo Martínez 2017-11-17 12:29:09 UTC 
Created attachment 363919 [details] [review]
build: Migrate from Intltool to Gettext

(In reply to Bastien Nocera from comment #2)
> Review of attachment 360010 [details] [review] [review]:
> 
> Can you also mention why you removed the "Icon=" line? Otherwise looks good.

Finally I've set it to gnome-session's namespace, following what other gnome's application do.

I've also extended the commit description with the reason of the change, which is that gettext does not handle properly the empty values, because it ends joining the key with the following line.
Comment 4 Ray Strode [halfline] 2018-01-08 21:27:08 UTC 
we don't actually use the Icon= key and don't ship an icon called org.gnome.SessionManager.png so I think the first cut was more right.
Comment 5 Ray Strode [halfline] 2018-01-08 21:29:26 UTC 
Attachment 363919 [details] pushed as 145ef74 - build: Migrate from Intltool to Gettext