Created attachment 359805 [details] [review]
Fix encoding of copyright headers

Some older files contain names in the copyright headers written in
ISO-8859-1 instead of UTF-8. This breaks with the new glib-mkenums
which expects a valid UTF-8 file.

Created attachment 359810 [details] [review]
Patch for libgda 5.24

Created attachment 359817 [details] [review]
Patch for libgda 5.24

Validity can be inspected using the following command:

    find . -name '*.h' -o -name '*.c' -exec isutf8 \{\} \;

isutf8 is part of moreutils.

Created attachment 359901 [details] [review]
Patch for libgda 5.24

Created attachment 359902 [details] [review]
Fix encoding of copyright headers

*** Bug 788283 has been marked as a duplicate of this bug. ***

A script for converting files is available on bug #788283.

on current libgda_5.2 attachment 359901 [details] [review] works; attachment 359902 [details] [review] fails

maybe is attachment 359902 [details] [review] for master?

(In reply to Andrea Zagli from comment #9)
> on current libgda_5.2 attachment 359901 [details] [review] [review] works; attachment
> 359902 [details] [review] fails
> 
> maybe is attachment 359902 [details] [review] [review] for master?

Yes, attachment 359902 [details] [review] is for master.

Note that some files contain names both in UTF-8 and ISO Latin 1. These patches manually fix all these mixed instances.

12429af2c0a40bb199ced605b7f7fab5ecc77e86 by Murray Cumming which attempts to fix this on master is incorrect as it breaks some UTF-8 names in the mixed files.

Created attachment 365917 [details] [review]
Minimal patch to get gtk-doc-enabled build work

Unfortunately, attachment 359902 [details] [review] no longer applies. This is not a proposed patch but a minimal patch to save time of people who want to build libgda with gtk-doc enabled

is attachment 365917 [details] [review] for master? if so, i think is better that you open another bug for master

Created attachment 365918 [details] [review]
patch to build with --enable-gtk-doc

patch if you want to build with --enable-gtk-doc; must be applied after attachment 359901 [details] [review]

(In reply to Andrea Zagli from comment #14)
> is attachment 365917 [details] [review] [review] for master? if so, i think is better
> that you open another bug for master

Yes, it is for master. I found there are discussion on patch for master, so I attached it here.

Created attachment 365921 [details] [review]
Patch for master

I updated my original patch to apply cleanly on master.

Created attachment 368240 [details] [review]
Fix encoding of copyright headers

Some names were still not fixed, this should do it.

Attachment 368240 [details] pushed as 1046e8f - Fix encoding of copyright headers