GNOME Bugzilla – Bug 787676
Background/Settings right click menu stays open when screen is locked
Last modified: 2017-10-04 16:28:53 UTC
Steps: 1. Become root, execute "sleep 5; loginctl lock-sessions" 2. Open the right click menu on the background ("Change Background", "System Settings", …) 3. Wait until the sleep finishes and the session is locked Result: * The right click menu stays open on top of the lock screen with no items Expected result: * Menu disappears entirely.
Same for context menu items for dash items. I wonder if there's any case where we don't want the menu to close, otherwise we could just hook into the existing session-updated handler in PopupMenuBase ...
I think context menus should always be closed. i.e. the only reason I can imagine for this to happen is that someone accidentally left a context menu open and left the computer without locking.
Created attachment 359798 [details] [review] popupMenu: Close menus on session mode changes (In reply to Benjamin Berg from comment #2) Not all menus are context menus though. But at a close look, we are already closing top bar menus on session mode changes, so I don't see a use case for *not* doing that for all menus generically (rather than fixing them one-by-one). We are already closing top bar menus on session mode changes, but as this behavior makes sense for any other menus as well - dash context menus or the background menu for instance - just generalize the behavior.
Ah, yes. Sounds good to me to generalize the code from the top bar menus to all menus.
Review of attachment 359798 [details] [review]: makes sense
Attachment 359798 [details] pushed as 7da5a76 - popupMenu: Close menus on session mode changes