After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787580 - [PATCH] StEntry: fix crash when hint actor is null
[PATCH] StEntry: fix crash when hint actor is null
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.25.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-12 10:27 UTC by Marc-Antoine Perennou
Modified: 2017-09-12 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix crash with no hint actor (946 bytes, patch)
2017-09-12 10:28 UTC, Marc-Antoine Perennou
committed Details | Review

Description Marc-Antoine Perennou 2017-09-12 10:27:29 UTC
In an extension which is using StEntry, I got a weird crash with 3.25.91.

Either adding a hint_actor or adding this patch fixes the issue.
Comment 1 Marc-Antoine Perennou 2017-09-12 10:28:12 UTC
Created attachment 359609 [details] [review]
Fix crash with no hint actor
Comment 2 Florian Müllner 2017-09-12 10:32:31 UTC
Review of attachment 359609 [details] [review]:

Obviously correct
Comment 3 Marc-Antoine Perennou 2017-09-12 19:41:05 UTC
Review of attachment 359609 [details] [review]:

pushed as 5ec0ad4e9cf8a88e3a715fdef4bf1f227b274d2d