After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787511 - assistant: Also update titlebar when the title changes
assistant: Also update titlebar when the title changes
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-10 17:08 UTC by Cosimo Cecchi
Modified: 2017-10-26 07:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
assistant: Also update titlebar when the title changes (1.28 KB, patch)
2017-09-10 17:08 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2017-09-10 17:08:26 UTC 
The assistant's title property was not getting notified when the page title changed.
Comment 1 Cosimo Cecchi 2017-09-10 17:08:28 UTC 
Created attachment 359470 [details] [review]
assistant: Also update titlebar when the title changes

Previously it would only update if the locale also changed, which
resulted in gis_page_set_title not appearing to do anything
Comment 2 Rui Matos 2017-10-25 15:39:10 UTC 
Review of attachment 359470 [details] [review]:

looks good, thanks
Comment 3 Cosimo Cecchi 2017-10-26 07:54:50 UTC 
Attachment 359470 [details] pushed as 1213a37 - assistant: Also update titlebar when the title changes

Thanks, pushed to master.