After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787497 - Disabling OFX, AqBanking or python-bindings support cripples the dist build target
Disabling OFX, AqBanking or python-bindings support cripples the dist build t...
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
git-master
Other All
: Normal minor
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-10 10:25 UTC by Geert Janssens
Modified: 2018-06-29 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Geert Janssens 2017-09-10 10:25:31 UTC 
When OFX, AqBanking or python-bindings is disabled (via configure or cmake command line switches) the source files for these optional features are not included in the dist tarball.

A subsequent attempt to build gnucash with any of these optional features starting from this dist tarball will fail due to missing source files.

The solution would be to ensure the distribution related parts of any of these optional features should always be triggered while running 'make/ninja dist' regardless of whether they are disabled.

Alternatively we should not allow to run make dist if any optional feature is disabled.
Comment 1 Guido Falsi 2017-09-26 13:12:14 UTC 
Hi,

While testing an update of the FreeBSD ports tree to the latest version (2.6.18) I discovered that the official source distribution file for that version is affected by this issue.

Some files required to build the python extension, like __init__.py,  are actually missing from the distribution.

I can work around this by adding the missing files in the FreeBSD port, but I think the distribution file should be rerolled or a fixup dot release made with all the relevant files.
Comment 2 Geert Janssens 2018-02-03 17:10:08 UTC 
I just checked with our release manager. He said he took care of the issue with the latest release (2.6.19).

Myself I went through current unstable and identified and fixed one final issue regarding gwenui. The distribution tarball will now correctly have all files regardles of whether aqbanking, ofx or python.
Comment 3 John Ralls 2018-06-29 23:59:26 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=787497. Please update any external references or bookmarks.