GNOME Bugzilla – Bug 787374
tests: libs/player test_play_media_info failure
Last modified: 2018-11-03 14:13:18 UTC
Created attachment 359283 [details] GST_DEBUG Log of failure libs/player.c:753:F:general:test_play_media_info:0: 'GPOINTER_TO_INT (state.test_data)' (2) is not equal to '1' (1) The "problem" is that more than one media info update gets emitted (because some information gets updated after a while, like bitrates).
*** Bug 787403 has been marked as a duplicate of this bug. ***
Created attachment 359333 [details] [review] player: Query duration and dimensions on pre-roll In order to guarantee that the duration (if present) is cached before creating the initial media_info. Avoids having two media info updates fired in a row (with the first ones having bogus/empty duration and dimensions). https://bugzilla.gnome.org/show_bug.cgi?id=787403
The above patch only fixes the issue for dimensions and duration. It doesn't solve it for tag updates
The reason why we get tag updates is because playbin detects tags at the inputselector level, which is before the queue which is before the sink. So you could be pre-rolled in paused ... but still have some tag updates (and therefore gstplayer would emit another media info update)
Comment on attachment 359333 [details] [review] player: Query duration and dimensions on pre-roll This patch isn't 100% correct. The core issue is that messages/events could quite normally happen in different orders, but the unit test is checking for very specific ordering of "events".
(In reply to Edward Hervey from comment #5) > Comment on attachment 359333 [details] [review] [review] > player: Query duration and dimensions on pre-roll > > This patch isn't 100% correct. The core issue is that messages/events could > quite normally happen in different orders, but the unit test is checking for > very specific ordering of "events". GstPlayer is trying to do all the events in a very specific, deterministic order. If that's not the case then that's the bug. Otherwise I expect this to be solved as part of https://bugzilla.gnome.org/show_bug.cgi?id=766898
Disabling unit test for now and marking this as a blocker for the following release (1.18)
commit 2f7d87a7d1670379e4873e1b8acaef1402fe720d (HEAD -> master, origin/master, origin/HEAD) Author: Edward Hervey <edward@centricular.com> Date: Sat Oct 27 13:37:38 2018 +0200 tests: Disable most gstplayer tests for now https://bugzilla.gnome.org/show_bug.cgi?id=787374
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/608.