After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787252 - [Patch] Migrate from intltool to gettext
[Patch] Migrate from intltool to gettext
Status: RESOLVED FIXED
Product: libgdata
Classification: Platform
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: libgdata-maint
libgdata-maint
Depends on:
Blocks: 763587
 
 
Reported: 2017-09-04 13:30 UTC by Niels De Graef
Modified: 2017-10-30 15:23 UTC
See Also:
GNOME target: 3.28
GNOME version: ---

Attachments
[Patch] Migrate from intltool to gettext (6.06 KB, patch)
2017-09-04 13:30 UTC, Niels De Graef 		none Details | Review
Update git.mk to latest upstream (4.56 KB, patch)
2017-09-27 13:08 UTC, Niels De Graef 		committed Details | Review
[Patch] Migrate from intltool to gettext (6.07 KB, patch)
2017-09-27 13:09 UTC, Niels De Graef 		committed Details | Review

Description Niels De Graef 2017-09-04 13:30:23 UTC 
Created attachment 359077 [details] [review]
[Patch] Migrate from intltool to gettext

See also https://wiki.gnome.org/MigratingFromIntltoolToGettext
Comment 1 Philip Withnall 2017-09-08 15:51:34 UTC 
Review of attachment 359077 [details] [review]:

::: Makefile.am
@@ -855,3 @@
 	po/remove-potcdate.sin \
 	m4/gtk-doc.m4 \
-	m4/intltool.m4 \

Port it to use $(GITIGNORE_MAINTAINERCLEANFILES_M4_GETTEXT) instead. (See the latest upstream git.mk: https://github.com/behdad/git.mk/commit/d6caf0d1b112dca1c7cb9324a48d57068e828a58.)

::: git.mk
@@ +222,3 @@
 		if test -f $(srcdir)/po/Makefile.in.in; then \
 			for x in \
+				ABOUT-NLS \

I would prefer git.mk to be updated from upstream (https://github.com/behdad/git.mk) in a separate commit.

::: po/Makevars
@@ +19,3 @@
+# the public domain; in this case the translators are expected to disclaim
+# their copyright.
+COPYRIGHT_HOLDER = Free Software Foundation, Inc.

That’s not right. The FSF is not the copyright holder for libgdata.

This should be `$(PACKAGE_STRING) authors`.

@@ +26,3 @@
+# detect it automatically by scanning the files in $(top_srcdir) for
+# "GNU packagename" string.
+PACKAGE_GNU =

This should be `no`.

@@ +42,3 @@
+# can write to without being subscribed, or the URL of a web page through
+# which the translators can contact you.
+MSGID_BUGS_ADDRESS =

This should be `$(PACKAGE_BUGREPORT)`.
Comment 2 Niels De Graef 2017-09-27 13:08:51 UTC 
Created attachment 360529 [details] [review]
Update git.mk to latest upstream

Update git.mk to latest upstream
Comment 3 Niels De Graef 2017-09-27 13:09:40 UTC 
Created attachment 360530 [details] [review]
[Patch] Migrate from intltool to gettext

Corrected version of the previous (now-obsolete) patch.
Comment 4 Philip Withnall 2017-10-30 15:03:03 UTC 
Review of attachment 360529 [details] [review]:

Great, thanks. Sorry for the slow review time — I didn’t get an e-mail notification of the new comments on the bug, for some reason.
Comment 5 Philip Withnall 2017-10-30 15:22:15 UTC 
Review of attachment 360530 [details] [review]:

This looks good to me, thanks.
Comment 6 Philip Withnall 2017-10-30 15:23:40 UTC 
Both pushed (I tweaked the commit message for the second patch). Thanks for fixing this!

Attachment 360529 [details] pushed as c1536b6 - Update git.mk to latest upstream