After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787212 - Errors/warnings from GIR when building master
Errors/warnings from GIR when building master
Status: RESOLVED OBSOLETE
Product: gnome-todo
Classification: Other
Component: General
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME To Do maintainer(s)
GNOME To Do maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-09-03 13:46 UTC by christophe.vda
Modified: 2020-11-25 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Build output when doing a rebuild. (16.53 KB, text/plain)
2017-09-03 13:46 UTC, christophe.vda
Details

Description christophe.vda 2017-09-03 13:46:47 UTC
Created attachment 359022 [details]
Build output when doing a rebuild.

When I do a clean git clone of the project in Gnome Builder and try to build, it gives these warnings. The build actually succeeds, but there seem to be problems as the software doesn't run correctly either. Using Fedora 26 with Gnome 3.24.
Comment 1 Daniel Boles 2017-09-03 13:50:24 UTC
(In reply to christophe.vda from comment #0)
> The build actually succeeds, but there seem
> to be problems as the software doesn't run correctly either.

What are the problems?
Comment 2 Daniel Boles 2017-09-03 13:51:28 UTC
I also get this, when building on Debian unstable with GLib 2.53.6 and GI 1.53.2 - just using a fresh git clone and terminal, no Builder or Flatpak involved.

my ninja output:

    ninja: Entering directory `/home/daniel/src/remote/gnome-todo/build'
    [107/108] Generating Gtd-1.0.gir with a custom command.
    cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/engine: No such file or directory [-Wmissing-include-dirs]
    cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/provider: No such file or directory [-Wmissing-include-dirs]
    cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/notification: No such file or directory [-Wmissing-include-dirs]
    cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/interfaces: No such file or directory [-Wmissing-include-dirs]
    cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/views: No such file or directory [-Wmissing-include-dirs]
    /home/daniel/src/remote/gnome-todo/src/notification/gtd-notification.h:42: syntax error, unexpected typedef-name, expecting identifier or '(' in 'typedef void (*GtdNotificationActionFunc) (GtdNotification *notification,' at 'GtdNotificationActionFunc'
    /home/daniel/src/remote/gnome-todo/src/notification/gtd-notification.h:43: syntax error, unexpected typedef-name, expecting identifier or '(' or '*' in '                                           gpointer user_data);' at 'gpointer'
    src/engine/gtd-manager.h:86: Warning: Gtd: gtd_manager_emit_error_message: argument function: Missing (scope) annotation for callback without GDestroyNotify (valid: call, async)
    src/gtd-task.c:729: Warning: Gtd: gtd_task_get_component: return value: Unresolved type: 'ECalComponent*'
    src/gtd-task.c:672: Warning: Gtd: gtd_task_new: argument component: Unresolved type: 'ECalComponent*'
    [108/108] Generating Gtd-1.0.typelib with a custom command.
Comment 3 christophe.vda 2017-09-03 13:55:24 UTC
(In reply to Daniel Boles from comment #1)
> (In reply to christophe.vda from comment #0)
> > The build actually succeeds, but there seem
> > to be problems as the software doesn't run correctly either.
> 
> What are the problems?

It shuts down randomnly after a few seconds at most. Gives this output: 


tk-Message: Failed to load module "pk-gtk-module"
Gtk-Message: Failed to load module "pk-gtk-module"

(gnome-todo:2): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(gnome-todo:2): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Comment 4 Daniel Boles 2017-09-03 14:05:29 UTC
Are you able to run it as follows:

  G_DEBUG=fatal-warnings gdb ./your-gnome-todo

and get backtraces from each such error?

On running that, gdb will start up, and you can just type the command "run" to start gnome-todo. It should then halt at each warning/critical, upon which you can type "bt" to get a backtrace, then paste that info here - then type "cont" to continue to the next error.

Having backtraces is how we can investigate why you get those errors.
Comment 5 Daniel Boles 2017-09-03 14:05:59 UTC
(They might turn out to need separate bug(s) of their own, but that's OK)
Comment 6 Iñigo Martínez 2017-09-12 06:11:47 UTC
(In reply to Daniel Boles from comment #2)
> I also get this, when building on Debian unstable with GLib 2.53.6 and GI
> 1.53.2 - just using a fresh git clone and terminal, no Builder or Flatpak
> involved.
> 
> my ninja output:
> 
>     ninja: Entering directory `/home/daniel/src/remote/gnome-todo/build'
>     [107/108] Generating Gtd-1.0.gir with a custom command.
>     cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/engine: No
> such file or directory [-Wmissing-include-dirs]
>     cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/provider: No
> such file or directory [-Wmissing-include-dirs]
>     cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/notification:
> No such file or directory [-Wmissing-include-dirs]
>     cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/interfaces:
> No such file or directory [-Wmissing-include-dirs]
>     cc1: warning: /home/daniel/src/remote/gnome-todo/build/src/views: No
> such file or directory [-Wmissing-include-dirs]

These are happening because when meson includes directories, it includes the directories in the source tree and also their counterpart in the build directory.

The `engine`, `provider`, `notification`, `interfaces` and `views` directories exist in the source tree but they don't in the _build tree because meson does not build anything in those, so the compiler fails to find those and warns about them:

You can see this in the `build.ninja` file:

COMMAND = /usr/bin/g-ir-scanner ... --no-libtool --namespace=Gtd --nsversion=1.0 --warn-all --output src/Gtd-1.0.gir --warn-all ... -I./. -I../. -I./src/engine -I../src/engine -I./src/provider -I../src/provider -I./src/notification -I../src/notification -I./src/interfaces -I../src/interfaces -I./src/views -I../src/views --add-include-path=./. --add-include-path=../. --add-include-path=./src/engine --add-include-path=../src/engine --add-include-path=./src/provider --add-include-path=../src/provider --add-include-path=./src/notification --add-include-path=../src/notification --add-include-path=./src/interfaces --add-include-path=../src/interfaces --add-include-path=./src/views --add-include-path=../src/views
Comment 7 André Klapper 2020-11-25 16:21:30 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all
older bug reports and feature requests in GNOME Bugzilla which have not seen
updates for a while.

If you still use gnome-todo and if you still see this bug / want this
feature in a recent and currently supported version, then please feel free to
report it at
https://gitlab.gnome.org/GNOME/gnome-todo/-/issues/
by following the guidelines at
https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines

Thank you for creating this report and we are sorry it could not be implemented
so far (volunteer workforce and time is limited).