After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 787109 - Valgrind false positive in ioctl() in btrfs file copy
Valgrind false positive in ioctl() in btrfs file copy
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.53.x
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-08-31 22:29 UTC by Philip Chimento
Modified: 2017-09-08 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
valgrind: Add false positive to suppressions file (1014 bytes, patch)
2017-08-31 22:29 UTC, Philip Chimento
committed Details | Review

Description Philip Chimento 2017-08-31 22:29:39 UTC
The BTRFS_IOC_CLONE ioctl will cause a false positive in Valgrind; Valgrind's memcheck tool checks that the third argument to ioctl() is a valid pointer, but some ioctls interpret that argument as an integer. That's what happens in this case, since a file descriptor is passed in.
Comment 1 Philip Chimento 2017-08-31 22:29:57 UTC
Created attachment 358896 [details] [review]
valgrind: Add false positive to suppressions file

Valgrind will check that the third argument to ioctl() is a valid
pointer, but some ioctls interpret that argument as an integer, and that
is the case here (it's a file descriptor), so this is a false positive.
Comment 2 Philip Withnall 2017-09-08 14:36:19 UTC
Review of attachment 358896 [details] [review]:

Looks good.
Comment 3 Philip Withnall 2017-09-08 14:37:05 UTC
Attachment 358896 [details] pushed as a72f57e - valgrind: Add false positive to suppressions file