GNOME Bugzilla – Bug 786978
The plugins notifications are displayed untranslated
Last modified: 2017-08-31 15:27:47 UTC
Using GNOME 3.25.90, the g-s-d plugins notifications display untranslated (the "tz has changed" for example), it seems setlocale() is not being called since the split and commit 950251e7
Created attachment 358685 [details] [review] call setlocale so the notifications are translated
Created attachment 358686 [details] [review] call setlocale so the notifications are translated same with a better description
Review of attachment 358686 [details] [review]: looks good, thanks. please push to the gnome-3-24 branch too
Review of attachment 358686 [details] [review]: commited as https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=9fddecc4, gnome-3-24 to come
commited to gnome-3-24 as well, https://git.gnome.org/browse/gnome-settings-daemon/commit/?h=gnome-3-24&id=d35f5edd
Created attachment 358733 [details] [review] common: include missing header files for LC_ALL
Review of attachment 358733 [details] [review]: oops, thanks!
Attachment 358733 [details] pushed as 1bf7e49 - common: include missing header files for LC_ALL
Could bug #782837 be related?
the bluetooth issue is a different one but I've an idea what is it and I'm going to write a patch for it as well did the missing include create build issues somewhere? I'm mostly curious because it builds fine here and there was previous commit that added setlocale() calls without that include, e.g https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=51d18a34 you maybe want to fix that one as well then?