After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786889 - [PlacesSidebar] Use "[dis]connect" instead of "[un]mount" for network mounts.
[PlacesSidebar] Use "[dis]connect" instead of "[un]mount" for network mounts.
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.22.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-28 10:34 UTC by António Fernandes
Modified: 2018-05-02 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description António Fernandes 2017-08-28 10:34:34 UTC 
Steps to reproduce:

    1) Right click a mounted network mount in the Places Sidebar.

Expected results:

    Popover menu has got a "Disconnect" action.

Actual results:

    Popover menu has got a "Mount" action.

---------

This is not consistent with "+ Other Locations" (GtkPlacesView), where the mount & unmount actions are labeled as connect & disconnect for remote mounts.

This also affects cloud drives, which have a permanent entry in the sidebar even if unmounted. Their popover menu has got a "Mount" action in the sidebar, but a "Connect" action in the Other Locations.
Comment 1 Daniel Boles 2017-08-28 11:22:04 UTC 
Right, GtkSidebarRow has no concept of whether or not an entry is a network location. I noticed this when adding the "Unmount" tooltip to the eject_button.
Comment 2 Daniel Boles 2017-09-03 10:13:12 UTC 
tagging as this could be fairly newcomer-friendly: just check what GtkPlacesView does to determine whether the location is on a network, and what GtkPlacesViewRow does with its resulting :is-network property, then replicate the relevant bits in
GtkSidebarRow.
Comment 3 GNOME Infrastructure Team 2018-05-02 18:59:04 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/894.