GNOME Bugzilla – Bug 786752
GdaTimestamp is private. Should be public
Last modified: 2017-11-04 20:38:54 UTC
Created attachment 358334 [details] [review] Proposed patch Compilation error was because of undefined type for GdaTimestamp.
Can someone throw a comment here. What should I wait for? My commit via GitHub pull request was rejected. Therefore, I created this bug report record. I did something wrong? Please advice. I have some other ideas for libgda modifications, but I afraid to push them until I totally understand the "contribution" process. Thanks.
What problem does this patch solve? You might mention that in the git commit message if you submit this as a git commit patch. For instance, you might use git format-patch HEAD^
Murray, I was trying to compile the library and got problem with GdaTimeStamp object. The solution was to move the declaration of the object from *.c (prvate) to *.h (public) scope. I just checked up to date master and this problem is not applicable anymore. I can't reproduce it. However, unless there is a reason to keep GdaTimeStamp private it may be moved to header. It looks like, this bug should be closed. Thank you for advice with patch generation. Will do better next time. Thanks.
The change seems to be intentional, though I'm not sure why for such a simple struct. You can now use the various get functions instead. Note that the API in git master is unstable, meaning that it can change.