After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786658 - housekeeping: Mention why gsd_is_removable_mount() is not removed
housekeeping: Mention why gsd_is_removable_mount() is not removed
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-22 23:46 UTC by Bastien Nocera
Modified: 2017-08-23 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
housekeeping: Mention why gsd_is_removable_mount() is not removed (836 bytes, patch)
2017-08-22 23:46 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-08-22 23:46:15 UTC 
.
Comment 1 Bastien Nocera 2017-08-22 23:46:19 UTC 
Created attachment 358184 [details] [review]
housekeeping: Mention why gsd_is_removable_mount() is not removed
Comment 2 Rui Matos 2017-08-23 08:42:33 UTC 
Review of attachment 358184 [details] [review]:

maybe add G_GNUC_UNUSED ?
Comment 3 Bastien Nocera 2017-08-23 09:10:15 UTC 
(In reply to Rui Matos from comment #2)
> Review of attachment 358184 [details] [review] [review]:
> 
> maybe add G_GNUC_UNUSED ?

That's not needed, it will be trimmed by the compiler, and doesn't produce any warnings as it's exported through a header. I tried to remove it not remembering that the file is copy/pasted in g-c-c.
Comment 4 Bastien Nocera 2017-08-23 09:17:08 UTC 
Attachment 358184 [details] pushed as 4fd6a8c - housekeeping: Mention why gsd_is_removable_mount() is not removed