After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786657 - housekeeping: Ignore the Retrode's low-space
housekeeping: Ignore the Retrode's low-space
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: housekeeping
unspecified
Other All
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-22 23:41 UTC by Bastien Nocera
Modified: 2017-08-23 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
housekeeping: Ignore the Retrode's low-space (1.91 KB, patch)
2017-08-22 23:41 UTC, Bastien Nocera
none Details | Review
housekeeping: Ignore the Retrode's low-space (1.90 KB, patch)
2017-08-23 09:01 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2017-08-22 23:41:45 UTC
.
Comment 1 Bastien Nocera 2017-08-22 23:41:49 UTC
Created attachment 358183 [details] [review]
housekeeping: Ignore the Retrode's low-space

It doesn't have any space left on its "hard drive", just enough to
be able to save the configuration file, and store the cartridge's ROM.
Comment 2 Rui Matos 2017-08-23 08:46:46 UTC
Review of attachment 358183 [details] [review]:

sure, feel free to push with the leak fixed

::: plugins/housekeeping/gsd-disk-space-helper.c
@@ +106,3 @@
                         return TRUE;
 
+        label = g_unix_mount_guess_name (mount);

unlike the other g_unix_mount_* calls here, this one returns an allocated string so needs freeing
Comment 3 Bastien Nocera 2017-08-23 09:01:47 UTC
Created attachment 358213 [details] [review]
housekeeping: Ignore the Retrode's low-space

It doesn't have any space left on its "hard drive", just enough to
be able to save the configuration file, and store the cartridge's ROM.
Comment 4 Rui Matos 2017-08-23 09:14:23 UTC
Review of attachment 358213 [details] [review]:

lgtm
Comment 5 Bastien Nocera 2017-08-23 09:16:56 UTC
Attachment 358213 [details] pushed as 940ddef - housekeeping: Ignore the Retrode's low-space