After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786597 - vaapi: should include required gstgl headers
vaapi: should include required gstgl headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-22 09:10 UTC by Julien Isorce
Modified: 2017-08-22 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: include required gstgl headers (924 bytes, patch)
2017-08-22 09:10 UTC, Julien Isorce 		none Details | Review
plugins: include main gstgl header (1.42 KB, patch)
2017-08-22 09:41 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Julien Isorce 2017-08-22 09:10:48 UTC 
Created attachment 358122 [details] [review]
plugins: include required gstgl headers

Currently it only includes <gst/gl/gstglcontext.h> and this header is about to not include all gstgl headers (see https://bugzilla.gnome.org/show_bug.cgi?id=784779). So to anticipate a build error I prefer to fix it before.

Since gstreamer-vaapi uses gst_gl_window_get_display, gst_gl_display_* let's include all required headers.
Comment 1 Víctor Manuel Jáquez Leal 2017-08-22 09:41:25 UTC 
Created attachment 358123 [details] [review]
plugins: include main gstgl header

Instead including particular gstgl header files in a header file
that doesn't export a gstgl symbol, the main gstgl header file is
included in gstvaapipluginutil.c where the symbols are used.
Comment 2 Víctor Manuel Jáquez Leal 2017-08-22 09:41:52 UTC 
my counterproposal :) wdyt?
Comment 3 Julien Isorce 2017-08-22 09:46:21 UTC 
Comment on attachment 358123 [details] [review]
plugins: include main gstgl header

Looks good!
Comment 4 Víctor Manuel Jáquez Leal 2017-08-22 09:57:22 UTC 
pushed attachment 358123 [details] [review] as commit 466c0548 - plugins: include main gstgl header