After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786592 - [PATCH] web-view: fix SIGSEGV when saving non-webpages
[PATCH] web-view: fix SIGSEGV when saving non-webpages
Status: RESOLVED NOTGNOME
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal major
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-22 06:09 UTC by Xiang Fan
Modified: 2017-08-23 14:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-web-view-fix-SIGSEGV-when-saving-non-webpages.patch (1.04 KB, patch)
2017-08-22 06:09 UTC, Xiang Fan 		rejected Details | Review

Description Xiang Fan 2017-08-22 06:09:12 UTC 
Created attachment 358106 [details] [review]
0001-web-view-fix-SIGSEGV-when-saving-non-webpages.patch

webkit_web_resource_get_data_finish() can return NULL without setting
error. This happens when e.g. attempting to save the page of a music
player or PDF viewer.
Comment 1 Michael Catanzaro 2017-08-22 17:01:50 UTC 
Review of attachment 358106 [details] [review]:

I noticed this the other day. Unfortunately the patch is not right. webkit_web_resource_get_data_finish() is broken. It is wrong to return NULL without setting error, because it is documented to return NULL only in case of error. This is a WebKit bug.
Comment 2 Michael Catanzaro 2017-08-22 17:02:48 UTC 
Do you want to report this on WebKit Bugzilla? We need to fix it there. It would be helpful if you could include a link to a particular website that is broken, because I never figured out how to reproduce this. I know I've hit this crash before, but I don't remember how.

Thanks for taking the time to report this.
This issue is most likely a bug in WebKit. Please report the bug to https://bugs.webkit.org/ including a link to this bug report and noting the version of WebKitGTK+ that you have installed. When reporting the WebKit bug, be sure to include the prefix '[GTK]' in the bug summary and select the 'WebKit Gtk' component.
Comment 3 Xiang Fan 2017-08-23 03:28:16 UTC 
Reported: https://bugs.webkit.org/show_bug.cgi?id=175870