After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786581 - libpeas builds loaders path incorrectly when using environment variable
libpeas builds loaders path incorrectly when using environment variable
Status: RESOLVED NOTABUG
Product: libpeas
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-21 21:35 UTC by Daniel Llewellyn
Modified: 2017-08-22 01:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against master to fix building loaders path referencing environment variable (946 bytes, patch)
2017-08-21 21:35 UTC, Daniel Llewellyn 		none Details | Review

Description Daniel Llewellyn 2017-08-21 21:35:01 UTC 
Created attachment 358094 [details] [review]
patch against master to fix building loaders path referencing environment variable

in 06a14dc39929bde4a4790bc8562156edb1aa608a the building of the path to find the loaders was changed away from a simple strdup of the environmnet variable. The new functionality builds the path incorrectly:

for the python loader the path build will be $PEAS_PLUGIN_LOADERS_DIR/python which causes peas to try to load $PEAS_PLUGIN_LOADERS_DIR/python/libpythonloader.so.

This path _should_ be $PEAS_PLUGIN_LOADERS_DIR/libpythonloader.so without the /python/ directory.

A patch against master is included, but this goes back to version 1.12 and is present in every tagged version between 1.12 and 1.21.
Comment 1 Garrett Regier 2017-08-22 01:40:57 UTC 
The environment variable is only supposed to be used for testing purposes and should never be set for any other reason. This is also why there is absolutely no documentation for it.