Created attachment 357950 [details] [review]
Replace custom override schema with per-desktop override

GSettings now recognizes per-desktop overrides that can be used
to change schemas' default values for a particular desktop. This
is not entirely unlike our existing custom override mechanism in
mutter, except that it is not limited to keys in org.gnome.mutter,
and it doesn't require a separate schema - the latter means that
we (and gnome-teak-tool) no longer have to figure out the correct
schema for the current login session and just use the original one.

Created attachment 357951 [details] [review]
prefs: Remove override system

With the support for per-desktop default values in GSettings, we
no longer need the mutter-specific override mechanism.

Created attachment 357952 [details] [review]
data: Replace override schema with per-desktop override

GSettings now recognizes per-desktop overrides that can be used
to change schemas' default values for classic mode, so use that
instead of the separate override schema we currently use with
mutter's custom override mechanism.

Created attachment 357953 [details] [review]
data: Use override for default alt-tab keybindings

Per-desktop overrides aren't limited to keys in org.gnome.mutter, so
we can use them instead of the alternate-tab extension to default to
the window switcher in the classic session.

Created attachment 357954 [details] [review]
extensions: Remove alternate-tab

Ever since GNOME 3.8 when gnome-shell started to provide the window
switcher functionality itself, the extension has only existed to
change the default behavior of the alt-tab shortcut in the classic
session. Now that we achieve this behavior with a per-desktop override,
there's no longer a need for the extension, so remove it altogether.

Users who prefer the window switcher over the default app switcher
can use the regular keyboard settings to assign a shortcut to the
"Switch windows" action.

https://developer.gnome.org/gio/stable/glib-compile-schemas.html

"By convention, vendor override files begin with nn_ where nn is a number from 00 to 99. Higher numbered files have higher priority (eg: if the same override is made in a file numbered 10 and then again in a file numbered 20, the override from 20 will take precedence)."

I would say that override files should start with 00_:
- 00_org.gnome.shell.gschema.override
- 00_org.gnome.shell.extensions.classic.gschema.override

Ubuntu or any other distro might want to say final word for default by installing higher priority override file.

Created attachment 357997 [details] [review]
Replace custom override schema with per-desktop override

Meh, override-overrides ...

Created attachment 357998 [details] [review]
data: Replace override schema with per-desktop override

Renamed override file

Excellent Florian!

I was planning helping on those changes once we are done with the GNOME Shell transition in ubuntu (after Feature Freeze), but great that you got timeto handle it yourself :) Quite happy that we head over the same common solution. I agree with the "you can ship "00_" where distros put higher versions (typically "10_") to override those.

Tell me if you need any help, once ofc the glib changes land (so not for 3.26).

Hello, do we have any update on this bug? I don't see any blocking point for the patches to be merged mainline, but maybe I didn't look too carefully?

thanks!

Gianfranco

Gianfranco, this bug is blocked on the glib bug. (See the "Depends on" field at the top of this bug.)

(In reply to Gianfranco Costamagna from comment #10)
> Hello, do we have any update on this bug? I don't see any blocking point for
> the patches to be merged mainline, but maybe I didn't look too carefully?

Yup, the patches depend on a GSettings feature that hasn't landed in glib master yet.