GNOME Bugzilla – Bug 786404
[PATCH] application: update application ID to match .desktop file
Last modified: 2017-08-27 02:47:55 UTC
Created attachment 357774 [details] [review] 0001-application-update-application-ID-to-match-.desktop-.patch Fixes missing window name and icon in Wayland.
Comment on attachment 357774 [details] [review] 0001-application-update-application-ID-to-match-.desktop-.patch LGTM, thanks.
Xiang Fan, do you have commit rights to git.gnome.org or do you need someone to push this for you?
(In reply to Jeremy Bicha from comment #2) > Xiang Fan, do you have commit rights to git.gnome.org or do you need someone > to push this for you? Thank you for commenting. Yes, I need someone to push this. I thought it was because of the freezes or something, but I don't really understand how this works. Can you please push this patch (and another one with accepted-commit_now https://bugzilla.gnome.org/show_bug.cgi?id=786189 )?
Sure, no problem. Pushing for you now. The way this works is the maintainer marked your patch as accepted-commit_now. But if you're new to GNOME and don't have git commit rights, you'll need to ping someone that does to commit the patch for you. I cam across this bug since it also affected me and didn't recognize your name so I thought I'd ask if you needed someone to commit it. :) When you're ready, this page describes applying for git commit rights: https://wiki.gnome.org/AccountsTeam/NewAccounts
(In reply to Jeremy Bicha from comment #4) > Sure, no problem. Pushing for you now. > > The way this works is the maintainer marked your patch as > accepted-commit_now. > > But if you're new to GNOME and don't have git commit rights, you'll need to > ping someone that does to commit the patch for you. > > I cam across this bug since it also affected me and didn't recognize your > name so I thought I'd ask if you needed someone to commit it. :) > > When you're ready, this page describes applying for git commit rights: > https://wiki.gnome.org/AccountsTeam/NewAccounts Thank you :)